Avoid build-time dependencies by prioritising binary over source dependencies for R#2277
Merged
asottile merged 1 commit intopre-commit:masterfrom Mar 5, 2022
Merged
Conversation
asottile
approved these changes
Mar 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the windows build for this repo.
Fixes the failing R build as discussed in #2272 (comment) by never installing R packages from source. This may create problems if no binary is available for a platform, as the common CRAN mirrors only provide binaries for macOS, Windows and popular Linux distributions.
If that's a problem, my PR could be altered to try a source installations after a binary installation failed, with some additional complexity that can't be easily tested in the R code that is provided as string here. I am not sure what platforms are officially supported here.