Add accessible name to 'Edit this page' icon#411
Merged
pradyunsg merged 3 commits intopradyunsg:mainfrom Apr 4, 2022
Merged
Conversation
pradyunsg
requested changes
Apr 4, 2022
Owner
pradyunsg
left a comment
There was a problem hiding this comment.
Aha! Nice catch!
This text needs to be piped through the translation scafolding.
hugovk
commented
Apr 4, 2022
Contributor
Author
hugovk
left a comment
There was a problem hiding this comment.
Internationalise text
Contributor
Author
|
Oops, that's the second time I've done a "review" instead of committing files from a batch! Let's try again... |
Co-authored-by: Pradyun Gedam <pradyunsg@gmail.com>
pradyunsg
approved these changes
Apr 4, 2022
Owner
pradyunsg
left a comment
There was a problem hiding this comment.
Awesome, thanks!
This is a gentle reminder to me that I need to consolidate RTD/non-RTD behaviours.
Contributor
Author
|
You're welcome! We're trying out Furo for the Pillow docs, currently |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running Lighthouse on https://pillow.readthedocs.io/en/latest/ gives a good accessibility score with one suggestion:
For the edit icon:
Here's a suggestion, following https://kittygiraudel.com/2020/12/10/accessible-icon-links/
<span class="visually-hidden">Edit this page</span>after the SVG, hidden but accessiblearia-hidden="true"to the<svg>to remove it from the accessibility treetitle="Edit this pageto the<a>, not strictly necessary but gives a tooltip