Pass verbosity to workers and show stack trace on error #935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Jan 22, 2022
Member
ondrejmirtes
left a comment
There was a problem hiding this comment.
Please modify it a bit - if you see the stack trace already, you don't have to run it with --debug.
And if the stack trace output isn't enabled, the correct advice is -v, not --debug.
Contributor
Author
|
Ineed, I updated the help message. |
Member
|
This still isn't correct. The message "Run PHPStan with -v option" is going to be printed even when the user is already running with "-v". Please modify the message so that it makes sense in both cases, and please post screenshots of both cases. Thanks. |
Contributor
Author
|
Hi @ondrejmirtes, I have updated the message to change whether the option has been set or not. Here is a screenshot without |
Member
|
Perfect, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows displaying the stack trace when an error is thrown in a worker. The stack trace is only displayed when either
-v,-vvor-vvvis passed to theanalysecommand.I believed the message could also be improved. For example, the error says "[...] in file src/...". However, it is the analysed file, not the file in which the error occurred.
This is the result:
