type combinator: fix integer ranges operations#89
Merged
ondrejmirtes merged 1 commit intophpstan:masterfrom Jan 11, 2020
Merged
type combinator: fix integer ranges operations#89ondrejmirtes merged 1 commit intophpstan:masterfrom
ondrejmirtes merged 1 commit intophpstan:masterfrom
Conversation
hrach
commented
Jan 5, 2020
| public function doFoo(array $integers, string $string, $mixedIsset, $mixedArrayKeyExists) | ||
| { | ||
| if (rand(0, 1) === 0) { | ||
| if (rand(0, 10) === 0) { |
Contributor
Author
There was a problem hiding this comment.
It seems that PhpStan already has some definition of pure functions and therefore using rand with same args is cached. 🤔 But not sure what is the current state.
Member
There was a problem hiding this comment.
Actually not yet, it currently dumbly caches rand(0, 1) result for all functions.
Member
|
I really don't understand the math, @JanTvrdik has to review this. Thank you. |
Member
|
OK, let's just see if anyone finds a bug in this :) Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another minute, another PR. 💦