object type: accomodate to properly resolve template type bound#85
object type: accomodate to properly resolve template type bound#85ondrejmirtes merged 1 commit intophpstan:masterfrom
Conversation
2450ce9 to
7ab804a
Compare
|
Finally. I was missguided about hundred times. Wrong fixes, fixes that broken something elsewhere later, etc. etc. Also, another (major) codechange will arrive in another PR... Please take a look, sometimes it's a magic for me. |
|
Yeah, I like this much better 👍 Although the |
7ab804a to
83b0857
Compare
Because I didn't know what is it exactly :D Ok, I've tried to rework it. Actually, many interfaces and theirs methods would benefit of documenting their meaning. |
|
I'd like the number of I'm really grateful for your contribution :) I'd say that after 22 hours, you're an expert now in this area :D |
|
Look at CompoundType implementations - it's a hack used to when |
|
Oh, you’ve already changed the code. Doesn’t something in TemplateObjectWithoutClassType also need to change? (I’m on mobile.) |
Need investigation, obviously we are missing more tests, changing it doesn't fix/break anything. |
|
Works great, thank you! Not sure what's going on in TemplateObjectWithoutClassType and why it doesn't need the changes... |
closes phpstan/phpstan#2763