Array unpacking support for string-keyed arrays #803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Nov 26, 2021
Member
ondrejmirtes
left a comment
There was a problem hiding this comment.
Hi, I think the else branch is still wrong, right?
} else {
$arrayBuilder->degradeToGeneralArray();
$arrayBuilder->setOffsetValueType(new IntegerType(), $valueType->getIterableValueType());
}
Contributor
Author
Are you saying this should also apply to the |
5d23a2e to
ed7ad43
Compare
ed7ad43 to
2f01813
Compare
2f01813 to
8de4928
Compare
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPStan didn't seem to have support for unpacking string keyed arrays: https://phpstan.org/r/e187af75-320b-4fa6-ba5a-54ceec396f42
This PR adds it only for PHP 8.1 and above.
I think my implementation may not be the best (especially the
$hasStringKeyhackery), feel free to override it or I'd be happy to change it according to suggestions 👍🏽