Skip to content

More precise array_chunk signature #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ondrejmirtes merged 2 commits into from
Jan 31, 2022
Merged

More precise array_chunk signature #709

ondrejmirtes merged 2 commits into from
Jan 31, 2022

Conversation

@staabm
Copy link
Contributor

@staabm staabm commented Oct 14, 2021 •
edited
Loading

@ondrejmirtes
Copy link
Member

ondrejmirtes commented Oct 15, 2021

The build failed - needs a fix in PHPStan.

@staabm
Copy link
Contributor Author

staabm commented Oct 15, 2021 •
edited
Loading

sorry didn't realize the build was broken. fixed now.

@ondrejmirtes
Copy link
Member

ondrejmirtes commented Nov 3, 2021

Better fix would be to also use positive-int as the constructor type.

@staabm
Copy link
Contributor Author

staabm commented Nov 3, 2021

adjusted as suggested

@staabm staabm changed the title More precise array_chunk signature More precise array_chunk signature Dec 22, 2021
@staabm
Copy link
Contributor Author

staabm commented Dec 22, 2021 •
edited
Loading

rebased (not sure what I should do with the remaining 3rd party error):

 ------ ----------------------------------------------------------------------- 
  Line   src/pocketmine/command/defaults/HelpCommand.php                        
 ------ ----------------------------------------------------------------------- 
  84     Parameter #2 $length of function array_chunk expects int<1, max>, int  
         given.                                                                 
 ------ -----------------------------------------------------------------------

@staabm @clxmstaab
More precise array_chunk signature
c416825 
fix Scheduler

fix cs

type __construct()

Update Scheduler.php

adjust test
@ondrejmirtes ondrejmirtes merged commit c013219 into phpstan:master Jan 31, 2022
@ondrejmirtes
Copy link
Member

ondrejmirtes commented Jan 31, 2022

Thank you.

@staabm staabm deleted the patch-2 branch April 4, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@staabm @ondrejmirtes