Fix parameter definition for Grpc\ChannelCredentials::createSsl #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copy from phan/phan#4534
This PR contains two fixes.
pem_root_certsto optional1st argument
$pem_root_certshas been changed to optional with this commitgrpc/grpc@52931a4#diff-d4d5d67134d6592b600cfc6179b56863f7d7b198c86384fb9bf0a86a5d20b765R142
all parameters to nullable
It is not nullable on PhpDoc, but the actual source code is nullable.
( And the behavior changes between null and the empty string🥺
PhpDoc fix is currently under review
grpc/grpc#27283