Fix false-positive when merging unions with +
#657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Sep 3, 2021
| } | ||
| } | ||
|
|
||
| if ($node instanceof Expr\AssignOp\Plus || $node instanceof Expr\BinaryOp\Plus) { |
Contributor
Author
There was a problem hiding this comment.
just moved this block before the integer-range math
ondrejmirtes
requested changes
Sep 3, 2021
tests/PHPStan/Analyser/data/math.php
Outdated
| assertType('int', $i - $j); | ||
| } | ||
|
|
||
| public function unionSum(): void |
Member
There was a problem hiding this comment.
When solving a specific issue, please always create a new file called bug-xxxx.php, thanks. The namespace in the file should also match.
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#5584