Make ReflectionAttribute generic
#640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Edit: I figured I have to add a runtime stub for |
Member
|
This is almost perfect, thank you! :) |
Contributor
Author
|
Oh no, I totally missed out @ondrejmirtes, since there isn't any common abstraction for reflection classes with |
Member
|
@vhenzl It's not. You should make whatever needs to be configurable through the extension constructor, then register it multiple times in .neon. |
Contributor
Author
|
Right, makes sense. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves phpstan/phpstan#5511.
I used an extension from
phpstan-doctrineas an exemple for the implementation ofReflectionClassGetAttributesMethodReturnTypeExtensionon but I'm not sure if it's correct as it allows for return types likearray<ReflectionAttribute<some random string>>.