Update signature of RedisCluster::__construct#62
Merged
ondrejmirtes merged 2 commits intophpstan:masterfrom Dec 20, 2019
codegain:patch-2
Merged
Update signature of RedisCluster::__construct#62ondrejmirtes merged 2 commits intophpstan:masterfrom codegain:patch-2
ondrejmirtes merged 2 commits intophpstan:masterfrom
codegain:patch-2
Conversation
ondrejmirtes
requested changes
Dec 20, 2019
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved version of #61 with no removals.
As I pointed out in phan/phan#3593 I'm getting this error in phpstan as well:
Class RedisCluster constructor invoked with 6 parameters, 2-5 required.The parameter was added to phpredis here: phpredis/phpredis#1355
See also:
https://github.com/zgb7mtr/phpredis_cluster_phpdoc/blob/master/src/RedisCluster.php#L96