Int and float toString() produces numeric-string#371
Merged
ondrejmirtes merged 2 commits intophpstan:masterfrom Nov 11, 2020
Merged
Int and float toString() produces numeric-string#371ondrejmirtes merged 2 commits intophpstan:masterfrom
ondrejmirtes merged 2 commits intophpstan:masterfrom
Conversation
Member
|
Hi, this needs a regression test. Probably add a new dataProvider in NodeScopeResolverTest::testFileAsserts() and test that |
3c10d55 to
539d006
Compare
Contributor
Author
|
@ondrejmirtes done |
ondrejmirtes
requested changes
Nov 11, 2020
7e3f1e3 to
65e7721
Compare
Contributor
Author
|
@ondrejmirtes fixed |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for phpstan/phpstan#4005