Fix scale parameter check in bc math return type extension#353
Merged
ondrejmirtes merged 1 commit intophpstan:masterfrom Oct 21, 2020
Merged
Fix scale parameter check in bc math return type extension#353ondrejmirtes merged 1 commit intophpstan:masterfrom
ondrejmirtes merged 1 commit intophpstan:masterfrom
Conversation
Contributor
|
Can't argue against that 😄 👍 |
Member
|
Perfect, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe that the "zero" check is incorrect for the third parameter.
There is a fallback to zero when the scale parametter is omitted and the default scale has not been set with the bcscale() function.
I added test cases covering the third parameter of the bcdiv and bcmod functions.
My changes should not break any of the existing tests. However, I would like to ask the extension author @eigan for a comment.
Problem example: https://phpstan.org/r/ef05165e-ca1e-4eb3-a26d-23d08c3d7b46