Having some strange behaviour with an integration test file I'm trying to add, @ondrejmirtes could you shed any light on this?

<?php

namespace MinMaxArrays;

function takesInt(int $int): void
{
}

function dummy(): void
{
	takesInt(min([1]));
	takesInt(min([]));
	takesInt(max([1]));
	takesInt(max([]));
}

/**
 * @param int[] $ints
 */
function dummy2(array $ints): void
{
	if (count($ints) > 0) {
		takesInt(min($ints));
		takesInt(max($ints));
	} else {
		takesInt(min($ints));
		takesInt(max($ints));
	}
}

/**
 * @param int[] $ints
 */
function dummy3(array $ints): void
{
	takesInt(min($ints));
	takesInt(max($ints));
}

just spews errors about takesInt not existing. The same code works fine on the playground so I don't understand the problem.

This is best tested in NodeScopeResolver::testFileAsserts(), it's just about type inference. We don't need to add integration test for the "accepts type" rules.

It seems that count($array) doesn't inform the type system that $array is definitely iterable at least once (or not), so my test case isn't working out as well as I'd like it to. For example, this case ought to be OK:

/**
 * @param int[] $ints
 */
function dummy2(array $ints): void
{
	if (count($ints) > 0) {
		takesInt(min($ints)); //should be fine
		takesInt(max($ints)); //should be fine
	} else {
		takesInt(min($ints)); //definitely not ok
		takesInt(max($ints)); //definitely not ok
	}
}

Looks like some cases aren't covered: https://phpstan.org/r/90c6a1be-8301-4d60-9715-634814964a6a (here it works for count($ints) !== 0).

You can look into it in TypeSpecifier, and also add some type assertions. A non empty array is array<int>&nonEmpty.

Seems like it only works for === and !==. ==, !=, > >=, < and <= seem excluded.

Alright, let’s merge this after the build passes and then I’ll ask you to fix the TypeSpecifier for these cases, thanks 😊

Thank you!