Skip to content

Add support for @phpstan-throws#292

Merged
ondrejmirtes merged 1 commit intophpstan:masterfrom
VincentLanglet:phpstanThrows
Aug 5, 2020
Merged

Add support for @phpstan-throws#292
ondrejmirtes merged 1 commit intophpstan:masterfrom
VincentLanglet:phpstanThrows

Conversation

@VincentLanglet
Copy link
Copy Markdown
Contributor

I messed up with the PR #291

@ondrejmirtes
Copy link
Copy Markdown
Member

I see the problem. It's not your fault.

@ondrejmirtes
Copy link
Copy Markdown
Member

Please rebase on top of master, the build should pass. Thanks.

@VincentLanglet
Copy link
Copy Markdown
Contributor Author

Sure, rebase done !

@ondrejmirtes
Copy link
Copy Markdown
Member

The tests related to this PR are failing.

@VincentLanglet
Copy link
Copy Markdown
Contributor Author

@ondrejmirtes I made some fixes. Can I do something for the Build/Phpstan failures ?

@ondrejmirtes
Copy link
Copy Markdown
Member

@VincentLanglet Thank you, I'm working on a fix right now :)

@ondrejmirtes ondrejmirtes merged commit 7c4f331 into phpstan:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants