functionMap: ZipArchive::open() returns true on success, int (error c…#253
Merged
ondrejmirtes merged 2 commits intophpstan:masterfrom Jun 22, 2020
pmmp:ziparchive-open
Merged
functionMap: ZipArchive::open() returns true on success, int (error c…#253ondrejmirtes merged 2 commits intophpstan:masterfrom pmmp:ziparchive-open
ondrejmirtes merged 2 commits intophpstan:masterfrom
pmmp:ziparchive-open
Conversation
Member
|
What about |
Contributor
Author
|
that works? Hm, I had no idea. |
Member
|
In that case I recommend you to check the documentation: https://phpstan.org/writing-php-code/phpdoc-types#literals-and-constants the functionMap goes through the same parser. |
Contributor
Author
|
build failure is bogus, doesn't look related to the PR |
Member
|
Thank you! Let me know if you find out more function types that could be upgraded with constants like this :) |
Contributor
Author
|
@ondrejmirtes Sure. I'm not actively scouring for them, but I stumble across them quite often during development :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ode) on failure