Skip to content

Make persistent_id parameter nullable#2188

Merged
ondrejmirtes merged 1 commit intophpstan:1.9.xfrom
greg0ire:redis-connect-signature-allow-null
Jan 19, 2023
Merged

Make persistent_id parameter nullable#2188
ondrejmirtes merged 1 commit intophpstan:1.9.xfrom
greg0ire:redis-connect-signature-allow-null

Conversation

@greg0ire
Copy link
Copy Markdown
Contributor

@greg0ire greg0ire commented Jan 18, 2023

It should be possible to pass a retry_interval without specifying a persistent_id.

Closes phpstan/phpstan#8733 (hopefully)

It should be possible to pass a retry_interval without specifying a
persistent_id.
@ondrejmirtes
Copy link
Copy Markdown
Member

1.9.x please.

@greg0ire greg0ire changed the base branch from 1.10.x to 1.9.x January 18, 2023 18:52
@ondrejmirtes ondrejmirtes merged commit 7fa21cf into phpstan:1.9.x Jan 19, 2023
@ondrejmirtes
Copy link
Copy Markdown
Member

Thank you.

@greg0ire greg0ire deleted the redis-connect-signature-allow-null branch January 19, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unsolvable Redis::connect override issue

2 participants