Fix filter_var() narrowing with unknown options#2146
Merged
ondrejmirtes merged 6 commits intophpstan:1.9.xfrom Jan 19, 2023
Merged
Fix filter_var() narrowing with unknown options#2146ondrejmirtes merged 6 commits intophpstan:1.9.xfrom
filter_var() narrowing with unknown options#2146ondrejmirtes merged 6 commits intophpstan:1.9.xfrom
Conversation
edf1929 to
86523f8
Compare
Contributor
Author
|
ah ok, the failing GenericsIntegrationTest / LevelsTest case is unrelated, exists also in other PRs |
Collaborator
|
This pull request has been marked as ready for review. |
staabm
reviewed
Dec 27, 2022
tests/PHPStan/Analyser/data/filter-var-returns-non-empty-string.php
Outdated
Show resolved
Hide resolved
staabm
reviewed
Dec 27, 2022
3bd6fa2 to
a7ec9e0
Compare
Collaborator
|
This pull request has been marked as ready for review. |
548a55c to
f9f17d5
Compare
f020a69 to
7205453
Compare
…ia `filter_var()`
Contributor
Author
|
sorry for the pressure, but what do you think about this one? it's big I know.. afterwards I should be finally able to re-use the logic and add support for |
Member
|
This is so complicated 😂 Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#8516
started the filter-var.php node scope resolver test file because I'd like to move some other filter-var tests over there
also: the fix is the first commit, the second one is still related, but the rest are unrelated fixes and improvements in additional commits.. thought I'll save you from 10 more PRs here :)