Don't re-calculate node-key over and over again #2073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Yes! 🎉 BTW if you'd find a way to include Blackfire in CI so it'd give us useful report each time, that'd be great! Otherwise the performance will get worse over time again. |
Contributor
Author
blackfire supports performance assertions. but this requires a paid plan. maybe there is room for a sponsoring by blackfire so we can achieve that |
Member
|
Blackfire sponsors PHPStan, maybe they could chip in with a plan too 😀 Currently I'm using Slevomat's paid account. |
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we call this method milions of times. lets do it upfront and re-use the value.
node-key calculation is fast already, but it requires a lot of method call across a lot of classes.
doing less calls saves this method call overhead.