Remove unnecessary file IO #2069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Dec 9, 2022
| return null; | ||
| } | ||
|
|
||
| $cacheItem = @include $filePath; |
Contributor
Author
There was a problem hiding this comment.
since we already swallow possible errors and validate the result we read just after that, we don't need to check beforehand whether $filePath actually is a file.
staabm
commented
Dec 9, 2022
| $filename = $this->declaringTrait->getFileName(); | ||
| } | ||
|
|
||
| if (!$isNativelyVariadic && $filename !== null && is_file($filename)) { |
Contributor
Author
There was a problem hiding this comment.
filemtime will return false when $filename is not a file. the code already handles this case.
lets drop this unnecessary file IO
Collaborator
|
This pull request has been marked as ready for review. |
Member
|
What's the command you're profiling this with? |
Contributor
Author
|
it is compared against phpstan 1.9.x @ da8413c |
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove file IO when not necessary. the IO subsystem can be super slow or at least performance can vary a lot dependent on when/where you read data from