IsSuperTypeOf refactorings#206
Merged
ondrejmirtes merged 2 commits intophpstan:masterfrom May 20, 2020
Merged
Conversation
ondrejmirtes
requested changes
May 17, 2020
Member
|
Hi, thanks, another weekend gone, right :D I've pointed out some mistakes, but I welcome any attempt to simplify this area. As you can see from the failing tests, the original behaviour with maybe vs. no was correct, at least in ObjectTypeTest. |
8e686b0 to
3e74a7c
Compare
hrach
commented
May 18, 2020
Comment on lines
67
to
72
Contributor
Author
There was a problem hiding this comment.
This was duplicated test, see index 6.
3e74a7c to
8e768ba
Compare
Contributor
Author
|
Ok, I have reworked the whole PR. This time I hopefully know what I was doing. I've tried to document the more complex things around class-string. Do you want to keep the first commit? Ideally this should be done everywhere and automatically. |
8e768ba to
88b5a1e
Compare
ondrejmirtes
approved these changes
May 20, 2020
Member
|
Thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here we go again... the last time I've changed ObjectType::isSuperTypeOf too, but in the end I've removed since it seemed too big change and you have suggested (my feeling, can't find it now) that it is not probably correct. This time I did it again and later remembered the previous trial... and this time I've finished this change. /shrug