Option usePathConstantsAsConstantString #2050
Conversation
39c74e8 to
aa7bb92
Compare
ondrejmirtes
left a comment
There was a problem hiding this comment.
The new ConstantStringType($file) part is repeated here. I'd like the code to change so that the last line call looks like this:
return $this->usePathConstantsAsConstantString ? $stringType : $stringType->generalize(GeneralizePrecision::moreSpecific());aa7bb92 to
e429015
Compare
|
Please remind me - why would need this again? It's causing problems with phpstan/phpstan#12203. |
|
@ondrejmirtes I think there is something explained here: phpstan/phpstan#8454 (reply in thread) |
|
It was needed when we evaluated paths to latte tempaltes with expressions containing DIR. Type was resolved as generic string not COnstantString with evaluated value. So I implemented this to be able to turn on treating results of expressions with DIR as constantString so it can be evaluated later. It seems like problem described in phpstan/phpstan#12203 is basically same thing we encountered. So this is not causing that problem but is solution to similar problem. |
|
I'd say this option shouldn't be needed. We should always strive for the type to be as precise as possible, and only degrade it (generalize it) in contexts where the precise type is counter-productive. |
|
Agreed. |
No description provided.