Added stubs for SplDoublyLinkedList, SplQueue and SplPriorityQueue#205
Closed
dktapps wants to merge 2 commits intophpstan:masterfrom
pmmp:spl-queue-stubs
Closed
Added stubs for SplDoublyLinkedList, SplQueue and SplPriorityQueue#205dktapps wants to merge 2 commits intophpstan:masterfrom pmmp:spl-queue-stubs
dktapps wants to merge 2 commits intophpstan:masterfrom
pmmp:spl-queue-stubs
Conversation
I made these for a project I'm working on, perhaps they'll be useful to someone else :)
Member
|
Merged, thank you! 6a38951
Yes, please do that :) |
Contributor
Author
|
I had a think about how to do this and the problem I keep running into is that the information needed to decide what the extract flags of PriorityQueue are is not present in the type system. If an SplPriorityQueue is passed to a function parameter, the callee doesn't know from the type system what the extract flags are. |
Member
|
Can you show a piece of code that demonstrates the problem you're facing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made these for a project I'm working on, perhaps they'll be useful to someone else :)
NB: SplPriorityQueue is very nasty because the return types depend on the
extract flags, which aren't available in the type system. It might be necessary to implement a dynamic return type extension for those.