Skip to content

TableErrorFormatter: allow editor url title configuration #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ondrejmirtes merged 1 commit into from
Dec 1, 2022
Merged

TableErrorFormatter: allow editor url title configuration #2035

ondrejmirtes merged 1 commit into from
Dec 1, 2022

Conversation

@janedbal
Copy link
Contributor

@janedbal janedbal commented Nov 29, 2022 •
edited
Loading

This allows me to have easily-copyable file+line even in GitLab CI even in docker and clickable locally.

parameters:
    editorUrl: 'phpstorm://open?file=%%relFile%%&line=%%line%%'
    editorUrlTitle: '%%file%%:%%line%%'

$ php bin/phpstan analyse --debug src/Parallel/ParallelAnalyser.php
Using php 8.1 from dockerhub
Note: Using configuration file /usr/src/myapp/phpstan.neon.
/usr/src/myapp/src/Parallel/ParallelAnalyser.php
 ------ ------------------------------------------------------------ 
  Line   ParallelAnalyser.php                                        
 ------ ------------------------------------------------------------ 
  195    Anonymous function has an unused use $internalErrorsCount.  
         ✏️  src/Parallel/ParallelAnalyser.php:195                   
 ------ ------------------------------------------------------------

Related: phpstan/phpstan#7796

@ondrejmirtes ondrejmirtes merged commit 6bde609 into phpstan:1.9.x Dec 1, 2022
@ondrejmirtes
Copy link
Member

ondrejmirtes commented Dec 1, 2022

Thank you! Please also send an update to the docs https://phpstan.org/user-guide/output-format#opening-file-in-an-editor with an explanation why one might want to change this. Thank you.

@janedbal janedbal mentioned this pull request Dec 1, 2022
Merged
@ondrejmirtes ondrejmirtes mentioned this pull request Dec 13, 2022
Closed
This was referenced Dec 13, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@janedbal @ondrejmirtes