Skip to content

Fix pathinfo($s, PATHINFO_ALL) return type#2014

Merged
ondrejmirtes merged 2 commits intophpstan:1.9.xfrom
staabm:pathinfo
Dec 19, 2022
Merged

Fix pathinfo($s, PATHINFO_ALL) return type#2014
ondrejmirtes merged 2 commits intophpstan:1.9.xfrom
staabm:pathinfo

Conversation

@staabm
Copy link
Copy Markdown
Contributor

@staabm staabm commented Nov 20, 2022

some tests fail with the current release: https://phpstan.org/r/adc64e75-4570-4aeb-acfd-bdcbf88ff872

PATHINFO_ALL is php8 only, see https://3v4l.org/4319K

@staabm staabm marked this pull request as ready for review November 20, 2022 12:59
@phpstan-bot
Copy link
Copy Markdown
Collaborator

This pull request has been marked as ready for review.

@staabm staabm marked this pull request as draft November 20, 2022 13:07
@staabm staabm marked this pull request as ready for review November 20, 2022 13:20
@phpstan-bot
Copy link
Copy Markdown
Collaborator

This pull request has been marked as ready for review.

@staabm staabm force-pushed the pathinfo branch 2 times, most recently from 30aedc2 to cec06f9 Compare December 2, 2022 10:20
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add two files with the same namespace please :)

@ondrejmirtes
Copy link
Copy Markdown
Member

Thank you!

@ondrejmirtes ondrejmirtes merged commit 2feb9a7 into phpstan:1.9.x Dec 19, 2022
@staabm staabm deleted the pathinfo branch December 19, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants