Fix bug 8212 #1995
Merged
Fix bug 8212 #1995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has to exist in global scope.
Member
|
Thank you! |
|
I have this issue in the latest PHPStan when there is a foreach wrapping around the code |
Member
|
@mityukov This is 3-year-old PR. Please open a bug report instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 8212 was closed in #1950 but the test added wasn't correct.
And, this revert commit a1605df made phpstan/phpstan#8212 not work again.
ConditionalExpressions should work in global scope too, so fixed by handling
canAnyVariableExistingetVariableType