Error on unknown parameter name in parameter conditional type#1966
Merged
ondrejmirtes merged 1 commit intophpstan:1.9.xfrom Nov 4, 2022
Merged
Error on unknown parameter name in parameter conditional type#1966ondrejmirtes merged 1 commit intophpstan:1.9.xfrom
ondrejmirtes merged 1 commit intophpstan:1.9.xfrom
Conversation
mad-briller
reviewed
Nov 4, 2022
| { | ||
| $this->analyse([__DIR__ . '/data/bug-8284.php'], [ | ||
| [ | ||
| 'Conditional return type references unknown parameter $callable.', |
Contributor
There was a problem hiding this comment.
there is no @return tag on the replaceCallback() method so is this error message a bit misleading?
it looks like it's really a conditional parameter type?
Member
There was a problem hiding this comment.
The feature is actually "conditonal types", not "conditional return types" - it was implemented as a first thing after we released "conditional return types".
Member
There was a problem hiding this comment.
But for the sake of backward compatibility, let's leave it like this.
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix phpstan/phpstan#8284