Skip to content

Update DateTimeZone::listAbbreviations signature#1962

Merged
ondrejmirtes merged 1 commit intophpstan:1.9.xfrom
franmomu:patch-2
Nov 5, 2022
Merged

Update DateTimeZone::listAbbreviations signature#1962
ondrejmirtes merged 1 commit intophpstan:1.9.xfrom
franmomu:patch-2

Conversation

@franmomu
Copy link
Copy Markdown
Contributor

@franmomu franmomu commented Nov 4, 2022

Apparently, based on https://www.php.net/manual/en/datetimezone.listabbreviations.php it cannot return false

Copy link
Copy Markdown
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to sync that with timezone_abbreviations_list

@franmomu
Copy link
Copy Markdown
Contributor Author

franmomu commented Nov 4, 2022

Would be nice to sync that with timezone_abbreviations_list

yeah sure

@ondrejmirtes ondrejmirtes merged commit 9b0b4ed into phpstan:1.9.x Nov 5, 2022
@ondrejmirtes
Copy link
Copy Markdown
Member

Thank you.

@franmomu franmomu deleted the patch-2 branch November 5, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants