Modify the built-in @method extension to look at @throws in __call
#1842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvanvelzen
reviewed
Oct 14, 2022
Comment on lines
69
to
71
| $classReflection->hasNativeMethod('__call') | ||
| ? $classReflection->getNativeMethod('__call')->getThrowType() | ||
| : null, |
Contributor
There was a problem hiding this comment.
For static methods this should look at __callStatic instead
Contributor
Author
There was a problem hiding this comment.
Thanks, fixed
87d6b3f to
5893ba6
Compare
rvanvelzen
reviewed
Oct 14, 2022
build/phpstan.neon
Outdated
| - 'PHPStan\Analyser\UndefinedVariableException' | ||
| - 'RuntimeException' | ||
| - 'Nette\Neon\Exception' | ||
| - 'Nette\MemberAccessException' |
Contributor
There was a problem hiding this comment.
This should no longer be necessary
Contributor
Author
There was a problem hiding this comment.
Indeed, done
ondrejmirtes
requested changes
Oct 14, 2022
| private array $parameters, | ||
| private bool $isStatic, | ||
| private bool $isVariadic, | ||
| private ?Type $throwType = null, |
Member
There was a problem hiding this comment.
Does not need to be optional
Contributor
Author
There was a problem hiding this comment.
I didn't know if i needed to be BC. Changed.
| ); | ||
| } | ||
|
|
||
| $isStatic = $methodTags[$methodName]->isStatic(); |
Member
There was a problem hiding this comment.
Since you're extracting this into a variable, you should use this variable on line 70.
Contributor
Author
There was a problem hiding this comment.
I forgot indeed, done
@method extension to look at @throws in __call
Member
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#8163