Fix return type of array_search() with constant array type haystack #1806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22fcd92 to
cb14292
Compare
Contributor
cb14292 to
fe102f9
Compare
staabm
reviewed
Nov 5, 2022
Comment on lines
11
to
19
Contributor
There was a problem hiding this comment.
please also add test-cases for the non-strict variant (leaving the 3rd param to false)
fe102f9 to
cdab81a
Compare
cdab81a to
980e931
Compare
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return type of
array_search()may be false unless we are sure that$haystackincludes a value identical to$needle.Closes phpstan/phpstan#3789