Skip to content

Fixed universal object crate classes not respecting @property annotations#1786

Merged
ondrejmirtes merged 1 commit intophpstan:1.8.xfrom
mad-briller:bug-7974
Oct 3, 2022
Merged

Fixed universal object crate classes not respecting @property annotations#1786
ondrejmirtes merged 1 commit intophpstan:1.8.xfrom
mad-briller:bug-7974

Conversation

@mad-briller
Copy link
Copy Markdown
Contributor

@mad-briller mad-briller commented Oct 3, 2022

closes phpstan/phpstan#7974

Doesn't resolve the issue that PropertiesClassReflectionExtension aren't called for classes that are universal object crates classes but it's a start.

@ondrejmirtes
Copy link
Copy Markdown
Member

Hi, this is nice! If you base it on top of 1.8.x, it's gonna be released sooner :)

@mad-briller mad-briller changed the base branch from 1.9.x to 1.8.x October 3, 2022 11:33
@mad-briller
Copy link
Copy Markdown
Contributor Author

@ondrejmirtes sorted!

@ondrejmirtes ondrejmirtes merged commit 35cac5a into phpstan:1.8.x Oct 3, 2022
@ondrejmirtes
Copy link
Copy Markdown
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@property annotations are ignored on classes that are universalObjectCrates.

2 participants