Optimize ConstantArrayType::isKeysSupersetOf() #1729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Sep 19, 2022
Member
|
Thank you, I really appreciate it! Do you also see how the logic that calls this method in TypeCombinator (along with mergeWith method) could be made faster? |
Contributor
Author
|
I have some code locally that seems to improve it. It needs some more work to work in general but it's promising :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly implements the suggestions from phpstan/phpstan#7666 (comment). Single-item arrays are not collapsed because that breaks a lot of tests and I couldn't really figure out why.