Add tip message to JSON error formatter#1727
Merged
ondrejmirtes merged 2 commits intophpstan:1.8.xfrom Oct 3, 2022
Merged
Conversation
72a2857 to
5a10897
Compare
Contributor
Author
|
sorry for pushing over and over here, but for whatever reason the tests failling in CI do not fail for me locally :-/ |
Member
|
The failures are feedback that this is a disrupting BC break for LevelsTestCase. Please unset the tip offset before saving/comparing the JSONs so that no changes are needed there. |
b848599 to
b5472a8
Compare
a59ef7e to
acd5c66
Compare
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#8022