Fixed double reporting of promoted properties.#1533
Merged
ondrejmirtes merged 2 commits intophpstan:1.8.xfrom Jul 23, 2022
Merged
Fixed double reporting of promoted properties.#1533ondrejmirtes merged 2 commits intophpstan:1.8.xfrom
ondrejmirtes merged 2 commits intophpstan:1.8.xfrom
Conversation
Member
|
Perfect, this makes sense. Could you add a test for a promoted parameter in MissingMethodParameterTypehintRule just to be sure it's reported? Thanks. |
Contributor
Author
|
added that testcase @ondrejmirtes |
b2770a8 to
a66d96f
Compare
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes phpstan/phpstan#7662
this could be a bit heavy handed, but my rationale is that the
MissingPropertyTypehintRulewill not surface anything that theMissingMethodParameterTypehintRulewont when analyzing promoted property definitions.