Update AppendIterator stub.#1517
Merged
ondrejmirtes merged 2 commits intophpstan:1.8.xfrom Jul 18, 2022
drupol:fix-append-iterator
Merged
Update AppendIterator stub.#1517ondrejmirtes merged 2 commits intophpstan:1.8.xfrom drupol:fix-append-iterator
AppendIterator stub.#1517ondrejmirtes merged 2 commits intophpstan:1.8.xfrom
drupol:fix-append-iterator
Conversation
Contributor
|
could you add the phpstan.org/try sample as NodeScopeResolver test? |
Contributor
Author
I just added it, but I'm not convinced. The test pass in 1.8.x and this branch. I guess my modifications doesn't have any impact here. Weird. |
Contributor
|
Sorry my mistake: we don't need a NodeResolverTest but one for the rule which emits the errors which can be seen in your snippet
|
Contributor
Author
|
Ok, going to remove the test. |
Contributor
|
the error we see in the phpstan sandbox is emitted here: therefore the repro case should be in |
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
AppendIteratorstub.Example on 3v4l: https://3v4l.org/gSPtO#v8.1.8
False positive on PHPstan: https://phpstan.org/r/36c91b68-01f7-404f-9fba-7a9e03d28953