Fix ConstantArrayType creation for preg_split with PREG_SPLIT_OFFSET_CAPTURE#1486
Closed
herndlm wants to merge 2 commits intophpstan:bug-7554from
Closed
Fix ConstantArrayType creation for preg_split with PREG_SPLIT_OFFSET_CAPTURE#1486herndlm wants to merge 2 commits intophpstan:bug-7554from
ConstantArrayType creation for preg_split with PREG_SPLIT_OFFSET_CAPTURE#1486herndlm wants to merge 2 commits intophpstan:bug-7554from
Conversation
Member
|
Awesome, great! What I'd love additionally is a test for https://github.com/phpstan/phpstan-src/blob/1.8.x/tests/PHPStan/Type/Constant/ConstantArrayTypeBuilderTest.php that shows the scenario that failed with the internal error 😊 |
Contributor
Author
|
Added something, but I'm pretty sure you meant it differently :) let me know please what to adapt |
Member
|
Oh, I didn't check the patch, I thought the bug was in ConstantArrayTypeBuilder, not the preg_split extension... |
Member
|
I merged it without the last commit, thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #1484
Looks like it was forgotten to explicitly specifiy
$nextAutoIndexescorrectly in that edge case. And then it falls back to[0]which can break theConstantArrayTypeBuilder(since the array keys0and1are explicitly specified already).I quickly looked through most of the other ConstantArrayType creations but did not find any more problems.
Fyi the 3 errors, that looked fine to me, are