Type a ranged value for filter_var(FILTER_VALIDATE_INT)#1443
Merged
ondrejmirtes merged 6 commits intophpstan:1.7.xfrom Jun 22, 2022
zonuexe:feature/typing-filter_var-range
Merged
Type a ranged value for filter_var(FILTER_VALIDATE_INT)#1443ondrejmirtes merged 6 commits intophpstan:1.7.xfrom zonuexe:feature/typing-filter_var-range
ondrejmirtes merged 6 commits intophpstan:1.7.xfrom
zonuexe:feature/typing-filter_var-range
Conversation
zonuexe
commented
Jun 19, 2022
Contributor
Author
There was a problem hiding this comment.
I don't plan to use it immediately, but it is possible to make FloatRangeType with -INF <= float <= INF.
ondrejmirtes
requested changes
Jun 20, 2022
Member
There was a problem hiding this comment.
TypeCombinator::intersect() instead please
Member
There was a problem hiding this comment.
TypeCombinator::union() please
Member
There was a problem hiding this comment.
IntegerRangeType::fromInterval() please
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#7494