Array after array_push / array_unshift call can still be empty#1431
Merged
ondrejmirtes merged 2 commits intophpstan:1.7.xfrom Jun 17, 2022
Merged
Array after array_push / array_unshift call can still be empty#1431ondrejmirtes merged 2 commits intophpstan:1.7.xfrom
array_push / array_unshift call can still be empty#1431ondrejmirtes merged 2 commits intophpstan:1.7.xfrom
Conversation
herndlm
commented
Jun 16, 2022
Member
|
Yeah, I guess this is fine :) Any reason why it's still a draft? |
Contributor
Author
|
Wanted to see if there's a better solution, e.g. for removing non-empty-array or in general for setting optional offsets. But I guess it's fine them for now |
Member
|
There's always a cleaner solution by providing a new |
Member
|
Thank you! |
Contributor
Author
|
I remember there was only one failure yesterday. Rebased just in case this fixes something :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#7424
The problem was that
ArrayType::setOffsetValueTypealways makes arrays non-empty, which is not wanted in this case (ifoptionalistruein the callback). And the solution here for simplicity reasons is to basically removeNonEmptyArrayTypefrom the result again if either optional is false or the original array was already not iterable at least once before setting the offset.An alternative might be to add an
$optionalarg tosetOffsetValueType, but I'm not sure about the impact of that yet.