Skip to content

Added <file>bin</file> into phpcs.xml. and applied it.#1394

Merged
ondrejmirtes merged 1 commit intophpstan:1.7.xfrom
sasezaki:bin_cs
Jun 3, 2022
Merged

Added <file>bin</file> into phpcs.xml. and applied it.#1394
ondrejmirtes merged 1 commit intophpstan:1.7.xfrom
sasezaki:bin_cs

Conversation

@sasezaki
Copy link
Copy Markdown
Contributor

@sasezaki sasezaki commented Jun 3, 2022

I could not see any reason to not .

@ondrejmirtes ondrejmirtes merged commit 2ef9a53 into phpstan:1.7.x Jun 3, 2022
@ondrejmirtes
Copy link
Copy Markdown
Member

ondrejmirtes commented Jun 3, 2022

Great, thank you! Although it comes with a catch or two:

  1. It wasn't applied to bin/phpstan because of the file extension
  2. Not all sniffs can apply to bin/phpstan - about using features from newer PHP versions, because the file isn't being downgraded during the compilation process in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sasezaki @ondrejmirtes