Skip to content

Specify types on get_parent_class() #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ondrejmirtes merged 9 commits into from
Oct 5, 2022
Merged

Specify types on get_parent_class() #1383

ondrejmirtes merged 9 commits into from
Oct 5, 2022

Conversation

@staabm
Copy link
Contributor

@staabm staabm commented Jun 1, 2022 •
edited
Loading

staabm
staabm commented Jun 2, 2022
View reviewed changes
@staabm staabm mentioned this pull request Sep 23, 2022
Closed
@staabm staabm changed the base branch from 1.7.x to 1.8.x September 23, 2022 12:37
@clxmstaab clxmstaab force-pushed the bug5552 branch 3 times, most recently from 63c70d3 to 823c7d0 Compare September 26, 2022 15:28
staabm
staabm commented Sep 26, 2022
View reviewed changes
src/Analyser/TypeSpecifier.php Outdated
Comment on lines 337 to 338
Copy link
Contributor Author

@staabm staabm Sep 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works arround the type error:

grafik

which is a separate bug, see #1396

Copy link
Contributor Author

@staabm staabm Sep 27, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in fb01d17 I factored out the existing logic into 2 new private methods.

that way we don't run into the #1396 bug and don't need the is_string based workaround

Copy link
Contributor Author

@staabm staabm Sep 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi @rvanvelzen, the refactoring might conflict with your existing #1761 PR.

@staabm staabm marked this pull request as ready for review September 26, 2022 15:47
@clxmstaab clxmstaab force-pushed the bug5552 branch 2 times, most recently from 3e7a923 to e91e1f1 Compare September 27, 2022 09:24
staabm
staabm commented Sep 27, 2022
View reviewed changes
src/Analyser/TypeSpecifier.php Outdated
Copy link
Contributor Author

@staabm staabm Sep 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this if block is the only new logic of this PR.

everything else is pre-existing logic which was just factored out into new private methods

@staabm staabm force-pushed the bug5552 branch 2 times, most recently from fb01d17 to eae128c Compare October 1, 2022 16:14
@staabm
Copy link
Contributor Author

staabm commented Oct 4, 2022

@ondrejmirtes if we could land this one it would unblock some of the already opened PRs for more TypeSpecifier goodness.

@ondrejmirtes ondrejmirtes changed the title specify types on get_parent_class() Specify types on get_parent_class() Oct 5, 2022
@ondrejmirtes ondrejmirtes merged commit 0b8b337 into phpstan:1.8.x Oct 5, 2022
@ondrejmirtes
Copy link
Member

ondrejmirtes commented Oct 5, 2022

Thank you.

@ondrejmirtes ondrejmirtes mentioned this pull request Oct 5, 2022
Closed
@staabm staabm deleted the bug5552 branch October 5, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support get_parent_class() in type specifier

3 participants

@staabm @ondrejmirtes @clxmstaab