Skip to content

Understand variadic arg types with @no-named-arguments#1349

Merged
ondrejmirtes merged 3 commits intophpstan:1.7.xfrom
jrmajor:no-named-args
May 28, 2022
Merged

Understand variadic arg types with @no-named-arguments#1349
ondrejmirtes merged 3 commits intophpstan:1.7.xfrom
jrmajor:no-named-args

Conversation

@jrmajor
Copy link
Copy Markdown
Contributor

@jrmajor jrmajor commented May 25, 2022

First step for phpstan/phpstan#5968.

jrmajor
jrmajor commented May 25, 2022
View reviewed changes
Comment thread src/Analyser/MutatingScope.php Outdated
Comment on lines 2613 to 2617
Copy link
Copy Markdown
Contributor Author

@jrmajor jrmajor May 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a simillar check in getFunctionType(). I'm not sure whether I need to change anything there, as it seems to work as is.

@jrmajor
Copy link
Copy Markdown
Contributor Author

jrmajor commented May 25, 2022

We would also need a rule preventing child class from declaring @no-named-arguments when the parent doesn't and a rule reporting usage of named arguments when this annotation is present.

@ondrejmirtes
Copy link
Copy Markdown
Member

ondrejmirtes commented May 28, 2022

Really really nice!

We would also need a rule preventing child class from declaring...

This should be done in MethodSignatureRule.

And the usage of named arguments in @no-named-arguments should be reported in FunctionCallParametersCheck.

@ondrejmirtes ondrejmirtes merged commit 87b213d into phpstan:1.7.x May 28, 2022
@ondrejmirtes
Copy link
Copy Markdown
Member

ondrejmirtes commented May 28, 2022

Thank you! Looking forward to follow-up PRs!

@ondrejmirtes ondrejmirtes mentioned this pull request May 28, 2022
Closed
@jrmajor jrmajor deleted the no-named-args branch June 3, 2022 20:30
@mhsdesign
Copy link
Copy Markdown

mhsdesign commented Oct 19, 2023

Fyi this seems to be the first followup #1400 but there seems to be no pr yet for preventing the calling site to use named args

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jrmajor @ondrejmirtes @mhsdesign