-
Notifications
You must be signed in to change notification settings - Fork 548
progress on named argument helper #1313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
regarding
atm the helper returns the call-args as is, since the helper only cares about args containing named-args. just added a test to demonstrate the helper returns the call unchanged. I think the helper is mostly complete as requested. next question would be on how to handle the returned |
5a6f35d to
26f7dbd
Compare
|
This is what I meant: c7969d0?diff=unified&w=1 There's still one test failure, please fix it. And I guess it's still not called for all relevant extension types, right?
I plan to rename the class to "ArgumentsNormalizer" in the next step so the name will no longer lie about the purpose. |
I have this change prepared locally but it still has some issues. at best we can merge here and progress in a new PR..? |
Yes :) Thank you! |
implement details mentioned in #1305 (comment) and remaining parts from #1301 (comment)