Skip to content

infer non-empty-string on substr() comparison with constant string #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ondrejmirtes merged 5 commits into from
May 21, 2022
Merged

infer non-empty-string on substr() comparison with constant string #1259

ondrejmirtes merged 5 commits into from
May 21, 2022

Conversation

@staabm
Copy link
Contributor

@staabm staabm commented Apr 28, 2022 •
edited
Loading

@staabm staabm marked this pull request as ready for review April 28, 2022 08:39
@staabm
Copy link
Contributor Author

staabm commented May 3, 2022

Todo: verify this doesnt hit the same problem as #1275

@clxmstaab clxmstaab force-pushed the substr branch 2 times, most recently from c2ec4dc to a24da7e Compare May 16, 2022 16:31
@staabm
Copy link
Contributor Author

staabm commented May 16, 2022

Todo: verify this doesnt hit the same problem as #1275

done. this one is good to go.

clxmstaab added 4 commits May 16, 2022 18:47
@clxmstaab @staabm
infer non-empty-string on substr() comparison with constant string
83ab13f 
infer non-empty-string on substr() comparison with constant string

try reducing unnecessary work

cs
@clxmstaab @staabm
more tests
0832edc
@clxmstaab @staabm
simplify
a5ad765
@clxmstaab @staabm
Revert "more tests"
d358ef7 
This reverts commit 995712c5c002f634775997564b18bd3da1830eb0.
@staabm
Copy link
Contributor Author

staabm commented May 20, 2022

Should this be re-targeted for 1.7.x?

@ondrejmirtes
Copy link
Member

ondrejmirtes commented May 21, 2022

Thanks :) Even if there isn't another 1.6.x release, I'm gonna merge it to 1.7.x right away.

@ondrejmirtes ondrejmirtes merged commit 871b710 into phpstan:1.6.x May 21, 2022
@staabm staabm deleted the substr branch May 21, 2022 13:29
@staabm staabm mentioned this pull request May 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@staabm @ondrejmirtes @clxmstaab