Fix ConstantArrayTypeBuilder optional keys via setOffsetValueType
#1225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sounds like a bigger general problem, but I figure it is more of an edge case. Found while working on something else. E.g. when building an array from scratch via
I am expecting the result type to be
array{0: 17|bool|null, 1?: 17|null, 2?: 17}because the last appended value is not optional any more. But it was stillarray{0?: 17|bool|null, 1?: 17|null, 2?: 17}. This PR fixes this. That exact example is added as test case.