Support variadic parameter in array_replace
#1209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herndlm
commented
Apr 13, 2022
staabm
reviewed
Apr 13, 2022
Contributor
I agree its hard to follow and the fix itself would have been a great separate PR. but lets see how ondrej thinks about that |
86dbeb8 to
d36d9ba
Compare
Member
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#7020
It was not my intention to completely refactor this extension, but it kind of happened while adding variadic support, sorry 😅 I normally would try to separate such things in multiple PRs. But the fix needed the refactor, the tests here were good enough and it's all quite local I think. Variadic support is only added via that one line checking
->unpackCC @staabm