Skip to content

Fix return signature of SimpleXMLElement::getDocNamespaces #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ondrejmirtes merged 1 commit into from
Apr 8, 2022
Merged

Fix return signature of SimpleXMLElement::getDocNamespaces #1190

ondrejmirtes merged 1 commit into from
Apr 8, 2022

Conversation

@Furgas
Copy link
Contributor

@Furgas Furgas commented Apr 8, 2022

SimpleXMLElement::getDocNamespaces can return false on invalid XML.

$xml = @new SimpleXMLElement('X', 1);
var_dump($xml->getDocNamespaces());

https://3v4l.org/GL12U

@ondrejmirtes ondrejmirtes merged commit 63cf02c into phpstan:1.5.x Apr 8, 2022
@ondrejmirtes
Copy link
Member

ondrejmirtes commented Apr 8, 2022

Thank you!

@Furgas Furgas deleted the fix-getdocnamespaces branch April 8, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Furgas @ondrejmirtes