Add support for int and bool args for strlen #1162
Conversation
There was a problem hiding this comment.
would toString also work here instead of these 3 separated cases?
(let the type system decide whether the scalar is castable to string)
There was a problem hiding this comment.
toString returns PHPStan\Type\Type.
I don't see any way to get value from it, maybe I don't understand how to do it
There was a problem hiding this comment.
I am not sure about it, but I guess this could work:
$toStringType = $constantScalar->toString();
if ($toStringType instanceof ConstantStringType) {
$len = strlen($toStringType->getValue());
}your added tests will tell :)
There was a problem hiding this comment.
what about float?
https://3v4l.org/XVRAE
maybe even null?
https://3v4l.org/J1pbq
There was a problem hiding this comment.
Good catch!
I will add support for these
|
I wonder how useful these are if this error is reported on them? https://phpstan.org/r/71827703-d925-432a-87a9-2e8b6fbbb291 |
This kind of errors can be manually suppressed, and return value can be used in the further calculations. I think it would be better (or at least it costs nothing) that PHPStan would be able to figure out the length of vars that are actually acceptable by |
|
Thank you. Please send any modifications as a future PR. |
No description provided.