Improve return types for array_fill_keys and array_combine
#1139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canvural
commented
Mar 29, 2022
7542a89 to
572960f
Compare
staabm
reviewed
Mar 29, 2022
572960f to
af04640
Compare
staabm
reviewed
Mar 29, 2022
f65641a to
419d8ef
Compare
ondrejmirtes
requested changes
Mar 29, 2022
Member
There was a problem hiding this comment.
With instanceof ArrayType condition, you're excluding:
non-empty-array(that's IntersectionType)- Unions of array shapes
Better solution is $keysParamType->isArray()->yes(). Instead of ->getItemType(), you should use ->getIterableValueType().
Feel free to fix other instances in this extension too - I see $valuesParamType instanceof ArrayType as well.
Contributor
Author
There was a problem hiding this comment.
Updated and added tests.
419d8ef to
87f4058
Compare
87f4058 to
ecd0dcb
Compare
ondrejmirtes
approved these changes
Mar 29, 2022
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves return types for
array_fill_keysandarray_combinefunctions. This two functions are kinda special, because they try to cast the key types to string. Sotruebecomes1, an object that has__toStringbecomesstringetc. This PR adds that.