Fix OOM #1137
Merged
Fix OOM #1137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
In phpstan-dba I am also persisting Type* objects to a file. |
Member
Author
|
Oh, good to know. Maybe you could persist their description only, and then unserialize the description using TypeStringResolver? |
Contributor
|
Will double check tomorrow |
Member
Author
|
Don't worry, I'm not gonna release a BC break, I'm gonna keep the cleanup for 2.0 :) Just suggesting something that I'm probably gonna do here too. |
This reverts commit 81f168c.
This was referenced Mar 28, 2022
Contributor
|
nice pragmatical solution for the MemoryCacheStorage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#6896
Closes phpstan/phpstan#6911