is_subclass_of do not infer anything when context is falsy #1124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86f84ce to
6523471
Compare
e1219b6 to
9dd2642
Compare
Member
|
Regression test for #6891 needs to be in NodeScopeResolverTest. |
9dd2642 to
95d1ec5
Compare
95d1ec5 to
cbb4c63
Compare
Contributor
Author
Done |
Contributor
|
👍 |
staabm
reviewed
Mar 27, 2022
| public function specifyTypes(FunctionReflection $functionReflection, FuncCall $node, Scope $scope, TypeSpecifierContext $context): SpecifiedTypes | ||
| { | ||
| if (count($node->getArgs()) < 2) { | ||
| if (!$context->truthy() || count($node->getArgs()) < 2) { |
Contributor
There was a problem hiding this comment.
This $context->truthy() check should be done in isFunctionSupported instead
Member
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#6891